Bump minimum python version to 3.8 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok with this change, but just one question, are we using any specific python features to justify this requirement? If so it would be nice to mention them in the commit message. |
|
Yes, as found here: amluto#55 At least python 3.6 should be required, but as 3.7 is almost on EOL, I used 3.8. I can mention it on the commit message if you think it would be nice |
Current 3.3 required version doesn't support typing annotations, which was introduced on 3.5.9. But since 3.7 is almost at EOL, require python 3.8. Link: amluto#55 Signed-off-by: Marcos Paulo de Souza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.