-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mr/falkor Puppet 4 version, transparent support for arrays and vagrant-based tests #12
Open
Falkor
wants to merge
51
commits into
arioch:master
Choose a base branch
from
Falkor:mr/falkor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Puppet 4 compliant released version of arioch/ulimit
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
metadata update
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
support for source and content
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Better README
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Final corrections and vagrant tests
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
forge score improvement
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
Forge score of 5.0
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
cosmetics in README
Signed-off-by: Sebastien Varrette <[email protected]>
Signed-off-by: Sebastien Varrette <[email protected]>
support for any type on value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Tom,
Here are the changes I made to publish the
ulimit
module under my own namespace on Puppet forge (see svarrette/ulimit) while waiting for your own new release as per Issue #9.I didn't want to touch it initially, but I couldn't prevent myself to extend the offered features and ensure a maximal scoring on Puppet Forge.
In short (sorry for the messy list of commits inherent to my internal versionning policy):
README.md
metadata.json
Vagrantfile
and provisioning scripts)tests/
ulimit::rule
:$ulimit_type
and/or$ulimit_item
parameters. Based on initial merge request of Jake Humphries aka Jake151 (yet I was not a fan of making it enfore the same array length)source
andcontent