Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for sub-route-map and continue in route-maps #1850

Merged
merged 13 commits into from
Aug 16, 2022
Merged

Feat(eos_cli_config_gen): Add support for sub-route-map and continue in route-maps #1850

merged 13 commits into from
Aug 16, 2022

Conversation

emilarista
Copy link
Contributor

@emilarista emilarista commented Jun 3, 2022 •
edited by tgodaA
Loading

Change Summary

Adds knobs for sub-route-map and continue in route maps.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

route_maps:
  <rm name>:
    sequence_numbers:
      <seq>:
        ...
        sub_route_map: <sub-RM>
        continue:
          enabled: < true | false >
          sequence_number: < integer >

How to test

Tested with molecule.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jun 3, 2022
@emilarista emilarista changed the title Sub route map Feat(eos_cli_config_gen): Add support for sub-route-map and continue in route-maps Jun 3, 2022
jonxstill
jonxstill previously requested changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the extra doc columns, looks OK.

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/route-maps.j2 Outdated Show resolved Hide resolved
@emilarista emilarista marked this pull request as ready for review June 15, 2022 09:02
@emilarista emilarista requested a review from a team as a code owner June 15, 2022 09:02
@emilarista emilarista force-pushed the sub_route_map branch 2 times, most recently from 3233dcf to cdbf52f Compare July 4, 2022 12:12
ClausHolbechArista
ClausHolbechArista approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team July 14, 2022 06:20
@carlbuchmann carlbuchmann marked this pull request as draft July 22, 2022 18:51
@emilarista emilarista marked this pull request as ready for review August 11, 2022 15:08
@ClausHolbechArista ClausHolbechArista dismissed jonxstill’s stale review August 12, 2022 16:01

stale review - comment has been addressed.

ClausHolbechArista
ClausHolbechArista approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team August 12, 2022 16:04
@emilarista emilarista requested a review from tgodaA August 16, 2022 07:07
tgodaA
tgodaA approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodaA tgodaA merged commit 92aa6a5 into aristanetworks:devel Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@jonxstill jonxstill Awaiting requested review from jonxstill

Assignees

@emilarista emilarista

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilarista @jonxstill @ClausHolbechArista @tgodaA