Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Create MLAG port-channels with network_ports data model #2011

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix: Create MLAG port-channels with network_ports data model #2011

merged 1 commit into from
Sep 7, 2022

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Create MLAG port-channels with network_ports data model.

Related Issue(s)

Fixes #2005

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Insert an extra blank switch name in the dataset created by network_ports, to force the existing logic for connected_endpoints to configure MLAG / ESI as applicable.

How to test

Added test coverage for MLAG to existing molecule scenario.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner August 23, 2022 08:35
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels Aug 23, 2022
tgodaA
tgodaA approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team September 6, 2022 10:01
gmuloc
gmuloc approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit bd19dba into aristanetworks:devel Sep 7, 2022
@ClausHolbechArista ClausHolbechArista deleted the network-ports-port-channels branch December 22, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Fix role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network_ports cannot create an mlag or esi port_channel
3 participants
@ClausHolbechArista @gmuloc @tgodaA