Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Support for custom naming of trunk groups #2021

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Support for custom naming of trunk groups

Related Issue(s)

Fixes #2003

Component(s) name

arista.avd.eos_designs

Proposed changes

# Trunk Group Names | Optional
trunk_groups:
  # "mlag" is the Trunk Group used for MLAG VLAN (Typically VLAN 4094).
  mlag:
    name: < trunk_group_name | default -> "MLAG" >
  # "mlag_l3" is the Trunk Group used for MLAG L3 peering VLAN (Typically VLAN 4093).
  # "mlag_l3" is also the Trunk Group used for VRF L3 peering VLANs
  mlag_l3:
    name: < trunk_group_name | default -> "LEAF_PEER_L3" >
  # "uplink" is the Trunk Group used on L2 Leaf switches when "enable_trunk_groups" is set.
  uplink:
    name: < trunk_group_name | default -> "UPLINK" >

How to test

Added molecule coverage in existing trunk group test only on some devices

  • No changes to devices using defaults
  • Correctly updated trunk group names on leafs with custom names.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner August 30, 2022 08:19
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 30, 2022
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team August 30, 2022 09:11
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 80cd8e5 into aristanetworks:devel Aug 30, 2022
@ClausHolbechArista ClausHolbechArista deleted the custom-trunk-group-names branch December 22, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Support for configurable trunk_group names
3 participants