-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add schema for sflow #2056
Conversation
- type int - convert from str
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be good to add this to all the other scenarios as well, since we have eos_cli_config_gen data everywhere, and everything may not be covered in all permutations inside eos_cli_config_gen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Agreed, added to all molecule scenarios in commit: 3baf0b3 |
Add schema for data model
Fix issue with
sflow.sample
type/auto conversion, and addingsflow.hardware_accelleration
key missed in PR #2036Additionally, now enforcing validation on the
eos_cli_config_gen
molecule scenario to trigger CI failure.See commit d3a41fd which triggered CI failure.
Checklist
Contributor Checklist
roles/eos_cli_config_gen/schemas/schema_fragments/<data_model_key>.schema.yml
.convert_types
on value that could be mixed type or misinterpreted like integers and numeric strings.convert_types: ['dict']
to the schema.convert_dicts
from thetemplates/eos/<>.j2
andtemplates/documentation/<>.j2
templates.molecule converge -s build_schemas_and_docs
to update schema and documentation.molecule converge -s eos_cli_config_gen
and verify no errors or changes to generated configs/docs.Reviewer Checklist
Reviewer 1:
convert_dicts
has been removed from templates as applicable.Reviewer 2:
convert_dicts
has been removed from templates as applicable.