Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): fix wrong type being returned for mac_address_table aging-time #2103

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Fix(eos_designs): fix wrong type being returned for mac_address_table aging-time #2103

merged 1 commit into from
Sep 27, 2022

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 27, 2022

Change Summary

  • Add parenthesis around walrus operator for mac_address_table aging-time to get the correct value assigned (int and not boolean)
  • Also checked that all other walrus assignment in eos_designs looked correct (did not verify if they are covered by tests)
  • Add test in eos_designs molecule scenario

Related Issue(s)

Fixes #2101

Component(s) name

arista.avd.eos_designs

Proposed changes

cf summary

How to test

molecule scenario for eos_designs_unit_tests. Chose an existing device to avoid adding unnecessary config

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner September 27, 2022 08:31
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels Sep 27, 2022
ClausHolbechArista
ClausHolbechArista approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

emilarista
emilarista approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 739982e into aristanetworks:devel Sep 27, 2022
@gmuloc gmuloc deleted the issue/2101 branch November 21, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilarista emilarista emilarista approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(eos_designs): Mac address table aging time return boolean instead of value
3 participants
@gmuloc @ClausHolbechArista @emilarista