Feat(eos_cli_config_gen): Add schema for banners #2117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schema for data model
Checklist
Contributor Checklist
roles/eos_cli_config_gen/schemas/schema_fragments/<data_model_key>.schema.yml
.convert_types
on value that could be mixed type or misinterpreted like integers and numeric strings.convert_types: ['dict']
to the schema.convert_dicts
from thetemplates/eos/<>.j2
andtemplates/documentation/<>.j2
templates.molecule converge -s build_schemas_and_docs
to update schema and documentation.molecule converge -s eos_cli_config_gen
and verify no errors or changes to generated configs/docs.Reviewer Checklist
Reviewer 1: Carl
convert_dicts
has been removed from templates as applicable.Reviewer 2: Claus
convert_dicts
has been removed from templates as applicable.