-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add schema for ipv6_icmp_redirect #2140
Feat(eos_cli_config_gen): Add schema for ipv6_icmp_redirect #2140
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
2def490
to
4a5ede7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add schema for data model
Checklist
Contributor Checklist
roles/eos_cli_config_gen/schemas/schema_fragments/<data_model_key>.schema.yml
.convert_types
on value that could be mixed type or misinterpreted like integers and numeric strings.convert_types: ['dict']
to the schema.convert_dicts
from thetemplates/eos/<>.j2
andtemplates/documentation/<>.j2
templates.molecule converge -s build_schemas_and_docs
to update schema and documentation.molecule converge -s eos_cli_config_gen
and verify no errors or changes to generated configs/docs.Reviewer Checklist
Reviewer 1: Claus
convert_dicts
has been removed from templates as applicable.Reviewer 2: Carl
convert_dicts
has been removed from templates as applicable.