Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add schema for qos #2155

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

mayurgs34
Copy link
Contributor

@mayurgs34 mayurgs34 commented Oct 6, 2022

Add schema for data model

Checklist

Contributor Checklist

  • Create schema fragment matching data model described in README.md and README_v4.0.md
    • README.md is most complete with all keys. README_v4.0 includes partial data models after conversion to lists.
    • Schema fragment path is roles/eos_cli_config_gen/schemas/schema_fragments/<data_model_key>.schema.yml.
    • Copy line 1-5 from another schema (comments and outer type:dict).
    • Refer to schema documentation for syntax and/or use YAML Lint plugin from Redhat in VSCode.
    • Use convert_types on value that could be mixed type or misinterpreted like integers and numeric strings.
  • If the data model has been converted from wildcard dicts:
    • Add convert_types: ['dict'] to the schema.
    • Remove convert_dicts from the templates/eos/<>.j2 and templates/documentation/<>.j2 templates.
  • Run molecule converge -s build_schemas_and_docs to update schema and documentation.
  • Test by running molecule converge -s eos_cli_config_gen and verify no errors or changes to generated configs/docs.

Reviewer Checklist

  • Reviewer 1: Carl

    • Verify that data model is fully covered in the described schema. Easiest by looking at the generated documentation.
    • Verify that convert_dicts has been removed from templates as applicable.
    • Verify no changes to configs/docs on any molecule scenario
    • Verify that CI pass
  • Reviewer 2: Claus

    • Verify that data model is fully covered in the described schema. Easiest by looking at the generated documentation.
    • Verify that convert_dicts has been removed from templates as applicable.
    • Verify no changes to configs/docs on any molecule scenario
    • Verify that CI pass

@mayurgs34 mayurgs34 added role: eos_cli_config_gen issue related to eos_cli_config_gen role EPIC - AVD Schema labels Oct 6, 2022
@mayurgs34 mayurgs34 requested a review from a team as a code owner October 6, 2022 06:21
@github-actions github-actions bot added the state: conflict PR with conflict label Oct 31, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 70e33f2 into aristanetworks:devel Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants