-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add schema for ipv6_static_routes #2182
Merged
ClausHolbechArista
merged 4 commits into
aristanetworks:devel
from
Shivani-chourasiya:ipv6_static_routes
Oct 31, 2022
Merged
Feat(eos_cli_config_gen): Add schema for ipv6_static_routes #2182
ClausHolbechArista
merged 4 commits into
aristanetworks:devel
from
Shivani-chourasiya:ipv6_static_routes
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
labels
Oct 10, 2022
ClausHolbechArista
previously approved these changes
Oct 13, 2022
carlbuchmann
requested changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update description for VRF name
...s/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ipv6_static_routes.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
force-pushed
the
ipv6_static_routes
branch
from
October 31, 2022 01:10
2b33457
to
68da485
Compare
carlbuchmann
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ClausHolbechArista
dismissed
their stale review
October 31, 2022 08:26
Things changed since I approved
carlbuchmann
force-pushed
the
ipv6_static_routes
branch
from
October 31, 2022 12:41
68da485
to
61c2085
Compare
ClausHolbechArista
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
EPIC - AVD Schema
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schema for data model
Checklist
Contributor Checklist
roles/eos_cli_config_gen/schemas/schema_fragments/<data_model_key>.schema.yml
.convert_types
on value that could be mixed type or misinterpreted like integers and numeric strings.convert_types: ['dict']
to the schema.convert_dicts
from thetemplates/eos/<>.j2
andtemplates/documentation/<>.j2
templates.molecule converge -s build_schemas_and_docs
to update schema and documentation.molecule converge -s eos_cli_config_gen
and verify no errors or changes to generated configs/docs.Reviewer Checklist
Reviewer 1: Claus
convert_dicts
has been removed from templates as applicable.Reviewer 2: Carl
convert_dicts
has been removed from templates as applicable.