Feat(eos_validate_state): custom fan & pwr states #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible_collections/arista/avd/roles/eos_validate_state/defaults/main.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_validate_state/defaults/main.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_validate_state/README.md
Outdated
Show resolved
Hide resolved
Allow custome states, more than just 'ok' for the fan and power supply states in the hardware validation task.
As discussed, the only default valid state for power supplies and fans should be 'ok'. If 'notInserted' needs to be allowed, it should be done via the [fan|pwr_supply]_states.
chetryan
force-pushed
the
custom_fan_pwr_states
branch
from
67d7299
to
e2e1987
Compare
chetryan
changed the title
carlbuchmann
approved these changes
Oct 27, 2022
ClausHolbechArista
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Allow custom states, more than just 'ok' for the
fan and power supply states in the hardware
validation task.
Related Issue(s)
No Issue found in github for this. This was raised internally.
Component(s) name
arista.avd.eos_validateProposed changes
How to test
There is currently no Molecule tests for
eos_validate_state.Checklist
User Checklist
Models:
notInsertedas was added to fan_statesnotInsertedwas added to fan_statesRepository Checklist