Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): make description, ip and gateway optional for management_interfaces #2224

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Fix(eos_cli_config_gen): make description, ip and gateway optional for management_interfaces #2224

merged 2 commits into from
Oct 26, 2022

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 25, 2022

Change Summary

  • Change the documentation template to not fail is management ip or gateway are not present.
  • Change the schema to relax the requirement of description, gateway and ip address for management interfaces
  • add test to eos_cli_config_gen molecule scenario

Related Issue(s)

Fixes #2220

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

cf summary

How to test

eos_cli_config_gen molecule scenario

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner October 25, 2022 13:32
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 25, 2022
@carlbuchmann carlbuchmann self-requested a review October 25, 2022 15:47
carlbuchmann
carlbuchmann approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann requested a review from a team October 25, 2022 15:49
@pvinci-arista
Copy link
Contributor

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 18c0df6 into aristanetworks:devel Oct 26, 2022
@gmuloc gmuloc deleted the issue/2220 branch February 8, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device documentation fails when Management IP is shutdown
4 participants
@gmuloc @pvinci-arista @carlbuchmann @ClausHolbechArista