Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: schema auto generated documentation and json schema #2251

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Fix: schema auto generated documentation and json schema #2251

merged 2 commits into from
Nov 3, 2022

Conversation

carlbuchmann
Copy link
Member

Change Summary

Fix schema auto-generated documentation and json schema to include properties when primary_key is defined.

Component(s) name

AVD schema

Proposed changes

  • update logic in avdtodocumentationschemaconverter.py
  • update logic in avdtojsonschemaconverter.py

How to test

Review update auto-generated eos_cli_config_gen documentation and JSON schema

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Nov 3, 2022
@carlbuchmann carlbuchmann marked this pull request as ready for review November 3, 2022 12:20
@carlbuchmann carlbuchmann requested a review from a team as a code owner November 3, 2022 12:20
@carlbuchmann carlbuchmann merged commit dfb1dcb into aristanetworks:devel Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA left review comments

@gmuloc gmuloc gmuloc left review comments

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
EPIC - AVD Schema rn: Fix role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlbuchmann @gmuloc @ClausHolbechArista @tgodaA