Refactor(eos_designs): Move custom_structured_configuration to python #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_designs
ClausHolbechArista
force-pushed
the
python-custom-structured-config
branch
4 times, most recently
from
e639e6f
to
facba23
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
python-custom-structured-config
branch
from
9402665
to
9973bd9
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
force-pushed
the
python-custom-structured-config
branch
from
9973bd9
to
a786c41
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
python-custom-structured-config
branch
from
e39e068
to
ead7752
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
type: Python filters
state: Documentation role Updated
labels
carlbuchmann
approved these changes
Nov 15, 2022
gmuloc
approved these changes
Nov 15, 2022
.../avd/roles/eos_designs/python_modules/custom_structured_configuration/avdstructuredconfig.py
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_designs/python_modules/custom_structured_configuration/avdstructuredconfig.py
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_designs/python_modules/custom_structured_configuration/avdstructuredconfig.py
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_designs/python_modules/custom_structured_configuration/avdstructuredconfig.py
Outdated
Show resolved
Hide resolved
tgodaA
reviewed
Nov 15, 2022
| @@ -0,0 +1,3 @@ | |||
| from .avdstructuredconfig import AvdStructuredConfig | |||
There was a problem hiding this comment.
I am confused why it is .avdstructuredconfig. I haven't used this feature before. So just curious to know.
There was a problem hiding this comment.
However, explicit relative imports are an acceptable alternative to absolute imports, especially when dealing with complex package layouts where using absolute imports would be unnecessarily verbose:
from . import sibling
from .sibling import example
There was a problem hiding this comment.
@tgodaA I will merge this, and we can discuss offline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move custom_structured_configuration to python
Component(s) name
arista.avd.eos_designsProposed changes
custom_structured_configurationand variousstructured_configkeys in python instead of jinja2struct_cfgkeys from generated structured configuration.How to test
Rerun molecule. Only diff is removing
struct_cfgkeys which we don't want in there (since they don't conform to the schema).Also tested with large customer repo. Runtime for structured_config without PR: 216 seconds. With PR: 88 seconds !!
Checklist
User Checklist
Repository Checklist