Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add flow tracking sampled support #2270

Merged
merged 7 commits into from
Nov 16, 2022

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Nov 8, 2022

Change Summary

Add Flow tracking suport on ethernet interfaces and port-channels

Related Issue(s)

Fixes #2233

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

for now only type sampled is supported (and available for configuration in EOS CLI anyway)

flow_trackings:
  - type: <str>
    sample: <int>
    trackers:
      - name: <str>
        record_export:
          inactive_timeout: <int>
          interval: <int>
          mpls: <bool>
        exporters:
          - name: <str>
            collector:
              ip_address: <str>
              port: <int>
            format:
              ipfix_version: <int>
            local_interface: <str>
            template_interval: <int>
    shutdown: <bool>
ethernet_interfaces:
    - name:  <Ethernet_interface_1>
      [...]
       flow_tracker_sampled: < flow_tracker_name >

port_channel_interfaces:
    - name:  <Port_channel_interface_1>
      [...]
       flow_tracker_sampled: < flow_tracker_name >

How to test

host added to eos_cli_config_gen molecule scenario

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner November 8, 2022 08:51
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 8, 2022
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): add flow tracking sampled support Feat(eos_cli_config_gen): Add flow tracking sampled support Nov 8, 2022
@ClausHolbechArista ClausHolbechArista requested review from a team and tgodaA November 9, 2022 14:01
@ClausHolbechArista ClausHolbechArista added this to the v3.8.0 milestone Nov 11, 2022
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit b9859e4 into aristanetworks:devel Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): support for flow-tracking
3 participants