Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): MAC address on management interfaces #2275

Merged
merged 10 commits into from
Dec 1, 2022
Merged

Feat(eos_cli_config_gen): MAC address on management interfaces #2275

merged 10 commits into from
Dec 1, 2022

Conversation

sugetha24
Copy link
Contributor

Change Summary

Adding support for Ma0 VIP for High Availability

Related Issue(s)

Fixes #2073

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Data Model:

  Management0:
    ip_address: 10.0.0.0
    mac_address: 00:1c:73:00:00:aa

intended config:

interface Management0
   ip address 10.0.0.0
   mac-address 00:1c:73:00:00:aa

How to test

molecule converge --scenario-name eos_cli_config_gen -- --limit management-interfaces

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Nov 9, 2022
@sugetha24 sugetha24 removed the request for review from carlbuchmann November 9, 2022 19:25
@ClausHolbechArista
Copy link
Contributor

I ran the molecule build_schemas_and_docs for you. If you do any changes to the schema, you have to rerun this molecule scenario and commit the updated files.

@sugetha24 sugetha24 changed the title Feat: Management0 VIP for HA Feat: MAC address on management iterfaces Nov 11, 2022
@sugetha24 sugetha24 marked this pull request as ready for review November 11, 2022 16:22
@sugetha24 sugetha24 requested a review from a team as a code owner November 11, 2022 16:22
gmuloc
gmuloc requested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the eos_cli_config_gen README for now (until we move to 4.0 we still need to keep it up to date). No need to update the README-v4.0.md file though

...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/management_interfaces.schema.yml Outdated Show resolved Hide resolved
gmuloc
gmuloc requested changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClausHolbechArista There is some fail in the CI on one of the new classes where it states hostname is missing: https://github.com/aristanetworks/ansible-avd/actions/runs/3464392573/jobs/5785924654#step:5:379

Not sure what is going on but worth investigating.

ansible_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.schema.yml Outdated Show resolved Hide resolved
...ollections/arista/avd/molecule/eos_cli_config_gen/intended/configs/management-interfaces.cfg Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista changed the title Feat: MAC address on management iterfaces Feat: MAC address on management interfaces Nov 16, 2022
gmuloc
gmuloc approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the README part is fixed.

ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md Outdated Show resolved Hide resolved
@carlbuchmann carlbuchmann changed the title Feat: MAC address on management interfaces Feat(eos_cli_config_gen): MAC address on management interfaces Nov 24, 2022
@ClausHolbechArista
Copy link
Contributor

@carlbuchmann I will let you review the requested change and merge.

carlbuchmann
carlbuchmann approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit e3bc851 into aristanetworks:devel Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@gmuloc gmuloc gmuloc approved these changes

@sarunac sarunac Awaiting requested review from sarunac

Assignees

@sugetha24 sugetha24

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVX Redundancy: Management0 VIP for High Availability
4 participants
@sugetha24 @ClausHolbechArista @gmuloc @carlbuchmann