ChangeControl: Resource API & Scheduling #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Inspect uri and modify based on /api | /cvpservice or if CVaaS enabled.
Adds support for getting all ChangeControls, single lookup by id, and addition of a schedule by id. This currently also includes a rough hack for enabling resource APIs that may be duplicating work on origin/resource-api.
Includes other assorted cleanup to make marshaling behave correctly. Error conditions seem to behave differently from what the API docs indicate, at least from what my manual prodding has shown. Additionally, it doesn't seem possible to manually enforce a user and date as the source of these changes -- looking at an API-written schedule on CVP 2022.1.0, the content is correct but has no user and a zero timestamp. Inserting these details ourselves gives a 400 Bad Request.
Reverts some early changes for URL processing in favour of the other in-progress branch.
Extends/modifies the ChangeControl resource types to allow for correct serialisation of create requests, and adds a method mirroring (python) cvprac to create a change control.
Testing confirmed that the API will return a HTTP code 400 if a provided time is illegal -- checking error fields is only useful some time *after* a schedule has occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for ChangeControl manipulation via the Resource API, in addition to change control scheduling. Functions added here mostly mirror those exposed by the python cvprac library in functionality. This includes the approval endpoints.
Includes the contents of
origin/resource-apidue to the different URL structure used by modern CVP versions.