Add shortcut to maximize a box #603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristocratos
requested changes
Sep 13, 2023
There was a problem hiding this comment.
@mdxio
I like the idea and effort but I'm not sure about the implementation.
When the GPU code gets merged there will be a dynamic number of extra boxes depending on number of gpus available and maintain a consistent experience (using shift as a modifier) will be difficult considering different keyboard layouts and so on.
Maybe a better approach would be to use a single key (sadly m is taken) and then the next number entered in a specific time period (say 1 second) would maximize the box.
You should probably also merge #604 in to this same PR since they are related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at solving the first part of #518 which is to maximize a box