Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace robin hood hash set/map with unordered-dense set/map #617

Closed
wants to merge 1 commit into from

Conversation

imwints
Copy link
Contributor

@imwints imwints commented Sep 13, 2023

Closes: #614

@aristocratos
Copy link
Owner

@nobounce
It might be the case that we could use std::unordered_map instead.
I believe the sizes of the containers used in btop probably never reach a size where a custom hash map would show any measurable difference in performance.

@imwints
Copy link
Contributor Author

imwints commented Sep 22, 2023

@aristocratos
Totally agree and didn't think of that at all.

Should I discard this PR then?

@aristocratos
Copy link
Owner

Probably better to create a new PR if you wanna do the std::unordered_map replacement, to not have a bunch of unnecessary commits in the history.

@imwints imwints closed this Sep 22, 2023
imwints added a commit to imwints/btop that referenced this pull request Sep 22, 2023
As per aristocratos#617 using a specialized
hash map/set is not worth the effort
imwints added a commit to imwints/btop that referenced this pull request Sep 22, 2023
As per aristocratos#617 using a specialized
hash map/set is not worth the effort
imwints added a commit to imwints/btop that referenced this pull request Sep 24, 2023
As per aristocratos#617 using a specialized
hash map/set is not worth the effort
imwints added a commit to imwints/btop that referenced this pull request Sep 24, 2023
As per aristocratos#617 using a specialized
hash map/set is not worth the effort
imwints added a commit to imwints/btop that referenced this pull request Oct 14, 2023
As per aristocratos#617 using a specialized
hash map/set is not worth the effort
@imwints imwints deleted the unordered-dense branch October 14, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Switch to new mainted hash map and set
2 participants