This repository has been archived by the owner on May 30, 2023. It is now read-only.
Modern tls support #12525
Merged
Modern tls support #12525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* --ssl-protocol= option now accepts 'tlsv1.2', 'tlsv1.1', 'tlsv1.0' and 'default' as well as the existing 'tlsv1', 'sslv3', and 'any'. * The default is now none of the above, but rather QSsl::SecureProtocols, which means "whatever subset of ANY is still considered secure and also supported by the OpenSSL library in use". (As of this writing, Qt's idea of "still considered secure" includes everything from SSLv3 on up, which is technically wrong -- SSLv3 has known breaks -- but we can live with. Qt currently doesn't have a way to select "TLSv1.0 and up".)
…riya#12524) New option --ssl-ciphers takes a colon-separated list of OpenSSL cipher names and sets the client cipher list to exactly that list. The default for this option is arranged to match Chromium 35, which has had its cipher selection optimized for the modern Web (see https://briansmith.org/browser-ciphersuites-01.html for rationales). (Newer versions are the same except that they also add ChaCha20-based ciphersuites, which OpenSSL 1.0.1 hasn't yet picked up.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #12524. See commit comments for details.