Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configuring for cloud9 IDE easier #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make configuring for cloud9 IDE easier #63

wants to merge 1 commit into from

Conversation

etherealite
Copy link

Getting this awesome project working in Cloud9 IDE can be a little tedious. Finding all the configuration strings and changing the port numbers to be compatible with Cloud9 is a bit on the arduous side.

This PR allows one to set the port for the webpack dev server by defining a single variable at the top of the server.js file.

@andrzejkrzywda
Copy link
Member

@etherealite thanks for the PR, it would be great to make it easier to run koans on Cloud9!

We'll just double-check if it works both on Cloud9 and locally and if so, it'll be merged.

@andrzejkrzywda
Copy link
Member

andrzejkrzywda commented Jun 27, 2016

After I tweaked it to run locally, it works.

I think the local version should be default, so maybe we need to apply this back:

-var host = 'react-koans-etherealite.c9users.io';
-var webpackPort = 8081;
+var host = 'localhost';
+var webpackPort = 9090;

and then add a README section explaining how to make it work on cloud9, then it would be best?

What's your opinion @etherealite? Can you help with this?

@etherealite
Copy link
Author

@andrzejkrzywda I'm glad for the opportunity to give back a little.

I completely agree that this branch should be changed so that webpack will bind to localhost:9090 by default.

I have only one difference of opinion on your proposal. I do not think cloud 9 installation instructions should have their own section in the README.md, as the subject is incidental to the existing directions. How about putting a link in the README.md? It could read something like: 'how to install in cloud9' and then point to a GitHub wiki page that had the directions.

@andrzejkrzywda
Copy link
Member

Good point with README vs GitHub wiki. Let's go for this.

@etherealite
Copy link
Author

Are the ES6 template literals ok to use, or should I make it ES5 compatible?

@voter101
Copy link
Contributor

Stuff from ES6 is fine, so template literals are OK to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants