-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog: v103 #1526
Comments
Thanks Pants. |
It might be clearer to state "click-to-play only" instead of "user" in: Line 1266 in 0dba336
That's what I've added in a comment in my overrides. Also, could you please add a one-liner to explain this setting? Line 771 in 0dba336
It's not clear from the UI or the user.js. The clearest explanation I've found is #119 (comment). |
:-(((( |
Thank you @Thorin-Oakenpants and others too. ❤️ |
Ci.nsIClearDataService.CLEAR_PERMISSIONS |
Ci.nsIClearDataService.CLEAR_CONTENT_PREFERENCES |
Ci.nsIClearDataService.CLEAR_DOM_PUSH_NOTIFICATIONS |
Ci.nsIClearDataService.CLEAR_CLIENT_AUTH_REMEMBER_SERVICE |
Ci.nsIClearDataService.CLEAR_CERT_EXCEPTIONS |
Well I'll say it: ALL HAIL PANTSCollect the set
You moved a lot of furniture around in 2800 and it's a lot better now (although I think this did get lost in the shuffle: |
Lines 757 to 759 in 0dba336
What is missing is toggling that checkbox flips sanitizeOnShutdown cookies/offlineapps/cache (we already have 2810 = true with other items to clear). I haven't fully tested what happens in all configs. If 2810 is enabled then it just flips those three items but if 2810 is disabled, it will obviously enable it and those three items, and the rest I'm not 100% sure on - I think it uses the migration logic (or maybe it recognizes user modified values) Anyway, I was going to add that somewhere, and simply say, leave this alone, we control it's state via 2800 ">History>" settings
|
Ah, I get it now – I vaguely wondered what
I guess a note at the top of 2800? |
2800 has become a sprawling behemoth .. I am loathe to add more to it: and it doesn't help that ESR102 behaves differently
= site settings .. like permissions (cookies+site data, notifications, geo ... etc ... ETP exceptions), zoom levels (except RFP ignores those), etc. The UI is
It's not as clean as it could be, and there are plans to tidy it up. Cookies + Active Logins + Cache should be next to offline website data under data. They should rename "offline website data" to "Site Data" to be consistent. Cache should be there as well, since it's linked to cookies + site data (and I hope they get around to cache respecting site exceptions to tidy that up so they all behave the same) I have explained What I'd like to see is something like
and everything under "Cookies + Site Data" should respect site exceptions, and be flipped by the "clear cookies + site data" checkbox. This would align naming and behavior |
Thanks for explaining, Rusty-Snake-In-Pants.
siteSettings isn't ambiguous once you know it, but it did require some digging which finally took me to the comment I linked above. The question for me arose because as I went through the list, seeing all the settings that are cleared and then encountering one that isn't, made me pause and wonder "why not"? There is an explanation for the others, after all, but not this one. Even this by itself would be helpful:
just to get a basic idea and move on with the rest of the user.js. What about my other suggestion? |
actually these (cert exceptions) are kept elsewhere, AFAIK edit this exact quote is nowhere to be found, I never quoted cert exceptions |
really? you can't extrapolate "user" to mean "click to play" |
Well, no. In fact, none of the 3 options are clear, with the way the pref is named. The term "blocking policy" implies under what conditions autoplay should be allowed or blocked. But the pref is actually about the duration for which an already given autoplay exemption stays in place. It could have been Because of this, the policy documentation needs to be read to understand the term used for each option. And the documentation itself is written in a slightly convoluted way and takes time to digest (which is weird because Mozilla is usually very good at simplifying things in their docs; maybe this was originally not meant to be a public document). I would rather go with:
Even if you don't want to change the other stuff, the policy documentation itself uses the term "click-to-play" for the third option, and is much easier to understand.
Sorry, that wasn't meant to be read as a quote. I'll change it to a code block. |
There was one pref, now to delete cookies have to:
It's not really convenient. |
None of the prefs you listed has changed. What do you try to say? And FTR |
Is there a difference between writing one pref in user.js and six? And the gmp-clearkey cookie is not deleted: #1199 |
|
four of those (downloads, formdata, history, sessions) have nothing to do with cookies or site data and are default true why did you change sessions - read the user.js as for the other two, you've always had to set those to delete on close - we always used to do it that way until I think about v91 we switched to lifetimepolicy and now back again
FFS: how many times do you need to set things |
What are they on the dropbox site for then? |
What has dropbox to do with this. |
It's not me, it's when you set the checkbox to delete cookies and site data.
I'm not talking about me, I'm talking about firefox users in general. |
You change it, read your own comment:
|
This is changed by firefox itself, so I wrote it down that way. That's what I'm talking about, the confusion due to the large number of prefs. |
that checkbox does not alter |
Yes, but with the new profile he created it in false. |
it is default true on new profiles. arkenfox also enforces it to true - the only reason it is false, is because you changed it in your overrides |
Default: |
the code for the checkbox does not touch .sessions.
you might be talking about the
We are halfway thru the FF104 cycle where the lifetime policy pref has been removed (and thus the migration code) AND arkenfox 103 moved lifetime policy to deprecated, so if you ran prefscleaner then it would have been reset, and if you didn't then since AF has clearonShutdown enabled, it would not reset anything as false |
ok, the penny dropped. new profile w/out arkenfox. This is not my problem. And if it is with arkenfox, then you would have had to override clearonshutdown master switch to false, which you would actually want to be true because you then asked it to sanitize shit on close, by playing with the UI I'm not going to bother looking it up, but the same logic as migration should also apply to toggling the UI. Default new profile does not have clearonshutdown enabled - so the code is doing exactly as expected (see previous comment) - but arkenfox does have it enabled, and it explicitly sets all values concerned. I do not care about a default new profile. I only care about arkenfox for you to have .sessions being changed to false, you would have to override clearonshutdown and check (perhaps uncheck first) the checkbox - and why are you using the UI - all the settings are actively set in the user.js, so the UI changes will not stick. You need to add them to overrides |
I needed the UI to know what to override. |
You do not need to override anything to delete cookies. Arkenfox has always deleted cookies in shutdown unless you said other. #1526 (comment) (2) |
date: 18-August-2022
FF103 release notes
FF103 for developers
FF103 security advisories
CHANGELOG
⭐ For the long story on the
clearOnShutdown*
andcookie.lifetimePolicy
pref changes, see the first post in #14919999: DEPRECATED / REMOVED
in user.js v103cookie.lifetimePolicy
: FF103 code will always reset this to 0, technically removed in FF104⭐ your friendly reminder to run prefsCleaner
NO STATS. NO ALL HAIL PANTS. UNTIL NEXT TIME.
The text was updated successfully, but these errors were encountered: