Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that most constants in FpParameters and elsewhere should be in Montgomery form. #69

Closed
Pratyush opened this issue Jun 19, 2020 · 3 comments · Fixed by #379
Closed

Document that most constants in FpParameters and elsewhere should be in Montgomery form. #69

Pratyush opened this issue Jun 19, 2020 · 3 comments · Fixed by #379
Labels
D-easy Difficulty: easy help wanted Extra attention is needed P-high Priority: high T-documentation Type: doc improvements

Comments

@Pratyush
Copy link
Member

No description provided.

@Pratyush Pratyush transferred this issue from arkworks-rs/snark Nov 20, 2020
@Pratyush Pratyush added T-documentation Type: doc improvements D-easy Difficulty: easy help wanted Extra attention is needed labels Nov 20, 2020
@ValarDragon
Copy link
Member

Should this issue now be closed?

@Pratyush
Copy link
Member Author

No, not quite; FpParameters still requires writing things down in Montgomery form =/

@Pratyush Pratyush added the P-high Priority: high label Sep 9, 2021
@Pratyush
Copy link
Member Author

Pratyush commented Feb 1, 2022

#379 fixes this.

@Pratyush Pratyush closed this as completed Feb 1, 2022
@Pratyush Pratyush mentioned this issue Sep 2, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-easy Difficulty: easy help wanted Extra attention is needed P-high Priority: high T-documentation Type: doc improvements
Projects
Documentation Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Fp code to use const generics, and more arkworks-rs/algebra
2 participants
@Pratyush @ValarDragon