Refactor Fp code to use const generics, and more
#379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
added
breaking-change
* Switches from hardcoded `FpXYZ` to `Fp<N>` based on const generics. * Moves Montgomery arithmetic to an optional backend
* Rename `field_new` macros. * Introduce `const fn`s for generating many constants. * Add default associated constants to reduce boilerplate.
weikengchen
reviewed
Jan 12, 2022
weikengchen
reviewed
Jan 12, 2022
mmagician
reviewed
Jan 13, 2022
Pratyush
commented
Jan 13, 2022
Comment on lines
+26
to
+40
| /// The modulus of the field. | ||
| const MODULUS: crate::BigInt<N>; | ||
|
|
||
| /// A multiplicative generator of the field. | ||
| /// `Self::GENERATOR` is an element having multiplicative order | ||
| /// `Self::MODULUS - 1`. | ||
| const GENERATOR: Fp<Self, N>; | ||
|
|
||
| /// Additive identity of the field, i.e. the element `e` | ||
| /// such that, for all elements `f` of the field, `e + f = f`. | ||
| const ZERO: Fp<Self, N>; | ||
|
|
||
| /// Multiplicative identity of the field, i.e. the element `e` | ||
| /// such that, for all elements `f` of the field, `e * f = f`. | ||
| const ONE: Fp<Self, N>; |
There was a problem hiding this comment.
The replacement for FpParameters, FpConfig, is much simplified; only the bare essentials need to be specified here, compared to implementation-details like R, CAPACITY, etc earlier.
Pratyush
commented
Jan 13, 2022
Comment on lines
+42
to
+61
| /// Set a += b. | ||
| fn add_assign(a: &mut Fp<Self, N>, b: &Fp<Self, N>); | ||
|
|
||
| /// Set a -= b. | ||
| fn sub_assign(a: &mut Fp<Self, N>, b: &Fp<Self, N>); | ||
|
|
||
| /// Set a = a + a. | ||
| fn double_in_place(a: &mut Fp<Self, N>); | ||
|
|
||
| /// Set a *= b. | ||
| fn mul_assign(a: &mut Fp<Self, N>, b: &Fp<Self, N>); | ||
|
|
||
| /// Set a *= b. | ||
| fn square_in_place(a: &mut Fp<Self, N>); | ||
|
|
||
| /// Compute a^{-1} if `a` is not zero. | ||
| fn inverse(a: &Fp<Self, N>) -> Option<Fp<Self, N>>; | ||
|
|
||
| /// Compute the square root of a, if it exists. | ||
| fn square_root(a: &Fp<Self, N>) -> Option<Fp<Self, N>> { |
There was a problem hiding this comment.
A lot of arithmetic methods have moved here, because this allows specializing the arithmetic implementation downstream
Pratyush
commented
Jan 13, 2022
Pratyush
commented
Jan 13, 2022
weikengchen
reviewed
Jan 15, 2022
weikengchen
reviewed
Jan 15, 2022
weikengchen
reviewed
Jan 15, 2022
weikengchen
reviewed
Jan 15, 2022
weikengchen
reviewed
Jan 15, 2022
weikengchen
approved these changes
Jan 15, 2022
Co-authored-by: Weikeng Chen <[email protected]>
Co-authored-by: Marcin <[email protected]>
|
Looks like the CI is passing (but, a corresponding update is needed in curves). |
|
I can make a PR for curves sometime early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #69
Close #180
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer