Allow running BLS12-381 curve test in the field-only mode #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weikengchen
commented
Aug 28, 2022
| pub struct Parameters; | ||
|
|
||
| #[cfg(feature = "bls12_381_curve")] | ||
| impl Bls12Parameters for Parameters { |
There was a problem hiding this comment.
The main reason for this change is that Parameters requires group definitions.
| @@ -22,12 +24,16 @@ pub mod g2_swu_iso; | |||
| pub use {fq::*, fq12::*, fq2::*, fq6::*, g1::*, g1_swu_iso::*, g2::*, g2_swu_iso::*}; | |||
|
|
|||
| #[cfg(test)] | |||
| #[cfg(feature = "bls12_381_curve")] | |||
There was a problem hiding this comment.
Since Fq is only loaded when bls12_381_curve, this effectively means that all the tests would require bls12_381_curve.
weikengchen
added
the
do-not-merge-now
6 tasks
6 tasks
|
I've included the fix for this in #463. If you could check and confirm that it works, that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At this moment, if one does the following, which is the case of ark-snark (!)
It would fail because the conditional compilation for bls12_381_scalar_field is not complete. It would report that several modules are missing.
This PR fixes so.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changedin the GitHub PR explorerN/A:
Pendingsection inCHANGELOG.md