Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change evaluation domain API for cosets #487

Merged
merged 16 commits into from
Sep 29, 2022

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Sep 25, 2022

Description

closes: #88


  • Added two constructors new_subgroup(subgroup_size) and new_coset(coset_size, offset). I kept the old constructor new(num_coeffs) since it contains logic to choose a subgroup size
  • Removed cosetFFT / cosetIFFT methods
  • Added get_coset(offset) convenience method
  • Removed divide_by_vanishing_poly_on_coset_in_place(). It wasn't clear if this method was appropriate anymore given domains can be coset domains.
  • Removed generator_inv() method and added offset() and offset_inv() methods
  • Moved evaluate_all_lagrange_coefficients() into a default implementation. Is there any reason not to do the same for the vanishing_polynomial and element methods?

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@andrewmilson andrewmilson changed the title DRAFT: Change evaluation domain API for cosets Change evaluation domain API for cosets Sep 25, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
poly/src/domain/mod.rs Outdated Show resolved Hide resolved
poly/src/domain/mod.rs Outdated Show resolved Hide resolved
poly/src/domain/utils.rs Outdated Show resolved Hide resolved
@Pratyush
Copy link
Member

Thanks for the PR! These changes all look great. Left some comments!

@Pratyush
Copy link
Member

Regarding moving elements and vanishing_polynomial and evaluate_vanishing_polynomial also into the default impl, I think it makes sense!

@Pratyush Pratyush mentioned this pull request Sep 29, 2022
poly/src/domain/mod.rs Outdated Show resolved Hide resolved
@Pratyush Pratyush merged commit 402e7f9 into arkworks-rs:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change evaluation domain API for cosets
2 participants