This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Replace ATE_LOOP_COUNT with its 2-NAF for MNT curves
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
reviewed
Aug 1, 2022
mnt4_298/src/curves/mod.rs
Outdated
| @@ -28,7 +28,15 @@ impl MNT4Parameters for Parameters { | |||
| // ``` | |||
| const TWIST_COEFF_A: Fq2 = Fq2::new(G1_COEFF_A_NON_RESIDUE, Fq::ZERO); | |||
|
|
|||
| const ATE_LOOP_COUNT: &'static [u64] = &[993502997770534912, 5071219579242586943, 2027349]; | |||
| // https://github.com/o1-labs/snarky/blob/9c21ab2bb23874604640740d646a932e813432c3/snarkette/mnt4_80.ml#L88 | |||
| const ATE_LOOP_COUNT_2: &'static [i8] = &[ | |||
There was a problem hiding this comment.
Maybe we should make this a const fn? So that we don't have to return arbitrary-looking arrays? (Not that the original constants have much meaning lol)
There was a problem hiding this comment.
How about attaching a sage script (since there's already a directory with such scripts for most curves)?
I think that if it's documented well where these consts come from, then the current approach is cleaner, especially that this constant is only ever used in its non-adjacent form (after this change).
There was a problem hiding this comment.
@Pratyush ping here and for the related PR arkworks-rs/algebra#445
weikengchen
reviewed
Aug 27, 2022
weikengchen
reviewed
Aug 27, 2022
weikengchen
reviewed
Aug 27, 2022
weikengchen
reviewed
Aug 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion to arkworks-rs/algebra#445
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer