Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: xradio wireless stopped working if those files were removed. #7292

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Bugfix: xradio wireless stopped working if those files were removed. #7292

merged 1 commit into from
Sep 24, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 23, 2024 •
edited
Loading

Description

Few months ago we did some extensive cleaning of deprecated sections in scripts. We also removed those two files, while they are needed for xradio to work properly. Lets put the back.

How Has This Been Tested?

Wifi start working if those files are present.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from a team as a code owner September 23, 2024 19:25
@github-actions github-actions bot added size/small PR with less then 50 lines BSP Board Support Packages labels Sep 23, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Bugfix Pull request is fixing a bug 11 Milestone: Fourth quarter release labels Sep 23, 2024
EvilOlaf
EvilOlaf approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is confirmed working ltgm

@igorpecovnik
Copy link
Member Author

Yeah, also reported in forums https://forum.armbian.com/topic/45334-orange-pi-zero-xradio-not-working-on-2408/#comment-202341

@igorpecovnik igorpecovnik merged commit 21a1628 into main Sep 24, 2024
17 checks passed
@igorpecovnik igorpecovnik deleted the inno-fix branch September 24, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilOlaf EvilOlaf EvilOlaf approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release BSP Board Support Packages Bugfix Pull request is fixing a bug Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @EvilOlaf