Merge pull request #2 from arminwinkt/revert-1-fix/typesenses-missing…

…-metadata Revert "fix: missing scout metadata for typesense search"
arminwinkt · Sep 24, 2024 · e3283cb · e3283cb
2 parents acb57e3 + 27191c8
commit e3283cb
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 53 deletions.
diff --git a/src/Engines/TypesenseEngine.php b/src/Engines/TypesenseEngine.php
@@ -392,19 +392,6 @@ public function map(Builder $builder, $results, $model)
             ->filter(static function ($model) use ($objectIds) {
                 return in_array($model->getScoutKey(), $objectIds, false);
             })
-            ->map(static function ($model) use ($hits, $objectIdPositions) {
-                $result = $hits[$objectIdPositions[$model->getScoutKey()]] ?? [];
-
-                foreach ($result as $key => $value) {
-                    if ($key === 'document') {
-                        continue;
-                    }
-
-                    $model->withScoutMetadata($key, $value);
-                }
-
-                return $model;
-            })
             ->sortBy(static function ($model) use ($objectIdPositions) {
                 return $objectIdPositions[$model->getScoutKey()];
             })

diff --git a/tests/Unit/TypesenseEngineTest.php b/tests/Unit/TypesenseEngineTest.php
@@ -183,46 +183,6 @@ public function test_map_ids_method(): void
         $this->assertEquals([1, 2, 3], $mappedIds->toArray());
     }
 
-    public function test_map_correctly_maps_results_to_models()
-    {
-        $engine = new TypesenseEngine($this->createMock(TypesenseClient::class));
-
-        $model = m::mock(stdClass::class);
-        $model->shouldReceive(['getScoutKeyName' => 'id']);
-        $model->shouldReceive('getScoutModelsByIds')->andReturn(Collection::make([
-            new SearchableModel([
-                'document' => [
-                    [
-                        'id' => 1,
-                        'name' => 'test',
-                    ]
-                ],
-                'geo_distance_meters' => ['location' => 5],
-                'highlights' => [],
-            ]),
-        ]));
-
-        $builder = m::mock(Builder::class);
-
-        $results = $engine->map($builder, [
-            'found' => 1,
-            'hits' => [
-                [
-                    'document' => ['id' => 1, 'name' => 'test'],
-                    'geo_distance_meters' => ['location' => 5],
-                    'highlights' => [],
-                ],
-            ],
-        ], $model);
-
-        $this->assertCount(1, $results);
-        $this->assertEquals(['id' => 1, 'name' => 'test'], $results->first()->toArray());
-        $this->assertEquals(
-            ['geo_distance_meters' => ['location' => 5], 'highlights' => []],
-            $results->first()->scoutMetadata()
-        );
-    }
-
     public function test_get_total_count_method(): void
     {
         // Sample search results with 'found' key