Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Fake User" setting for traits + reorder trait UI #1646

Merged
merged 2 commits into from
Apr 11, 2020

Conversation

MoritzBrueckner
Copy link
Collaborator

@MoritzBrueckner MoritzBrueckner commented Apr 10, 2020

Traits now have a Fake User setting. If set to true, the trait will be exported even if it is deactivated. This fixes #1529.

Screenshot of the "Fake User" option

I've also slightly changed the trait UI:
Before:
traits_before

After:
traits_after

@Sandy10000
Copy link
Contributor

Thank you for your support. I downloaded the file and checked it using the test file "Trait.blend".

Check the fake user checkbox of the trait "Bullet" set in the object "projectile".
1

Press the space bar to shoot one shot and hit the floor to disappear. No problems occur while repeating this.

Shooting the second shot before it disappears after shooting the first one will freeze without error. It seems that there are still some problems.

@MoritzBrueckner
Copy link
Collaborator Author

MoritzBrueckner commented Apr 11, 2020

Oh ok I had this issue as well (only if two bullets are visible at the same time) but after changing the code to the current one (I had some different ideas before) I could not reproduce it anymore. The problem is probably at some other place, I will try to find the issue, thanks for testing :)

Edit: I tried it again (with a clean redownload of your test file from the above linked issue + stashed my other armory changes in Git so that they don't interfere) and I still cannot reproduce that problem anymore. It just works, I can spam the space key as much as I want and it doesn't freeze.
But as I said I had the same issue before so something is still weird, but possibly not related to this PR.

@luboslenco luboslenco merged commit 82cee15 into armory3d:master Apr 11, 2020
@MoritzBrueckner MoritzBrueckner deleted the trait-fake-user branch April 11, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic node "Trait" does not work depending on conditions
3 participants