Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drupal-drush-sql-cli command #65

Merged
merged 2 commits into from
Aug 26, 2015
Merged

Conversation

joddie
Copy link
Contributor

@joddie joddie commented Aug 25, 2015

This adds a command and keybinding to run drush sql-cli in a properly set-up Emacs SQL buffer.

This is fairly lightly tested (e.g., I have not tried using it with anything other than MySQL) so feedback is welcome.

@arnested
Copy link
Owner

This looks very interesting!

Just tried it out very shortly myself and it works with mysql as well for me. I think I'll just merge it and then we'll see if we get reports from other database backends. It's not like it is breaking other functionality.

In my setup I have no database prompt in sql-interactive-mode but that is not related to your code - it even happens with emacs -Q.

I also have some encoding stuff that's not right (the content in the database is not show with the right encoding). That's not a problem when connecting M-x sql-mysl directly to the database but the problem could possibly be in some of my other configuration. And I don't think of it as a show stopper for getting this awesome feature out in the wild and gather feedback.

arnested added a commit that referenced this pull request Aug 26, 2015
Add `drupal-drush-sql-cli` command
@arnested arnested merged commit 36ea400 into arnested:develop Aug 26, 2015
@joddie joddie deleted the feature/sql-cli branch September 6, 2015 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants