Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpcs output parsing #72

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Fix phpcs output parsing #72

merged 1 commit into from
Apr 20, 2016

Conversation

arnested
Copy link
Owner

We couldn't catch the Drupal standard if it was the next to last standard as in:

The installed coding standards are MySource, PSR2, Zend, Squiz, PHPCS, PEAR, Drupal and PSR1

Maybe there used to be an Oxford comma in the output of phpcs? Or maybe we have always been failing on this.

Fixes #71.

@arnested arnested merged commit a02e1dd into develop Apr 20, 2016
@arnested arnested deleted the fix-phpcs-output-parsing branch April 20, 2016 19:50
@arnested arnested mentioned this pull request Apr 20, 2016
Closed
@arnested arnested restored the fix-phpcs-output-parsing branch April 20, 2016 19:59
@arnested arnested deleted the fix-phpcs-output-parsing branch April 20, 2016 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arnested