Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update jackson and arrow version #68

Merged
merged 11 commits into from
Feb 3, 2022
Merged

update jackson and arrow version #68

merged 11 commits into from
Feb 3, 2022

Conversation

myuwono
Copy link
Collaborator

@myuwono myuwono commented Feb 3, 2022 •
edited
Loading

In this PR:

  • Update Kotlin to 1.6.10
  • Update Jackson to 2.13.1
  • Update arrow to 1.0.0
  • Update test engine to Kotest 5.0.2
  • Update gradle to 6.1.1

fixes #67

@myuwono myuwono requested a review from nomisRev February 3, 2022 06:33
@myuwono
Copy link
Collaborator Author

myuwono commented Feb 3, 2022

@nomisRev i'm not sure who to tag for this repo. I wonder if we should publish the jackson modules separately vs the main arrow proper?

myuwono
myuwono commented Feb 3, 2022
View reviewed changes
...tions-jackson-module/src/main/kotlin/arrow/integrations/jackson/module/NonEmptyListModule.kt
@@ -16,7 +16,7 @@ import com.fasterxml.jackson.databind.type.CollectionType
import com.fasterxml.jackson.databind.type.TypeFactory
import com.fasterxml.jackson.databind.util.StdConverter

object NonEmptyListModule : SimpleModule(PackageVersion.VERSION) {
object NonEmptyListModule : SimpleModule(NonEmptyListModule::class.java.canonicalName, PackageVersion.VERSION) {
Copy link
Collaborator Author

@myuwono myuwono Feb 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now required due to the change in the way module registration prevents duplicate using the string module name. by default it's the artifact id of jackson.. joansmith/jackson-databind@d672b18

myuwono
myuwono commented Feb 3, 2022
View reviewed changes
gradle.properties
@@ -4,12 +4,11 @@ VERSION_NAME=1.0.0-SNAPSHOT
LATEST_VERSION=0.13.2
# Versions
ANIMALS_SNIFFER_VERSION=1.5.0
ARROW_VERSION=0.13.2
ARROW_VERSION=1.0.0
Copy link
Collaborator Author

@myuwono myuwono Feb 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nomisRev i've bumped this from 0.13.2 to 1.0.0 - if i remember correctly they both should be compatible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump this to 1.0.1, too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i hit another problem with the ank-gradle-plugin with 1.0.1 so i'm keeping it 1.0.0 for the time being, let's address it in the new issue

myuwono
myuwono commented Feb 3, 2022
View reviewed changes
gradle.properties
JUNIT_VINTAGE_VERSION=5.6.3
KOTLIN_TEST_VERSION=3.3.3
KOTLIN_VERSION=1.4.32
JACKSON_MODULE_KOTLIN_VERSION=2.13.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jackson is now updated to 2.13.1

myuwono
myuwono commented Feb 3, 2022
View reviewed changes
gradle.properties Outdated
KOTLIN_VERSION=1.4.32
JACKSON_MODULE_KOTLIN_VERSION=2.13.1
KOTEST_VERSION=5.0.2
KOTLIN_VERSION=1.6.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlin is updated to 1.6.0

myuwono
myuwono commented Feb 3, 2022
View reviewed changes
gradle.properties Outdated
KOTLIN_TEST_VERSION=3.3.3
KOTLIN_VERSION=1.4.32
JACKSON_MODULE_KOTLIN_VERSION=2.13.1
KOTEST_VERSION=5.0.2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test engine is upgraded to kotest 5.0.2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade it to 5.1.0?

@myuwono myuwono changed the title Issue/update jackson update jackson and arrow version Feb 3, 2022
i-walker
i-walker approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@i-walker i-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myuwono 🙌🏾

i-walker
i-walker reviewed Feb 3, 2022
View reviewed changes
gradle.properties Outdated
KOTLIN_TEST_VERSION=3.3.3
KOTLIN_VERSION=1.4.32
JACKSON_MODULE_KOTLIN_VERSION=2.13.1
KOTEST_VERSION=5.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade it to 5.1.0?

gradle/wrapper/gradle-wrapper.properties
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.0.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade gradle to 7.3.3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, I'll raise another issue to track the gradle upgrade

gradle.properties
@@ -4,12 +4,11 @@ VERSION_NAME=1.0.0-SNAPSHOT
LATEST_VERSION=0.13.2
# Versions
ANIMALS_SNIFFER_VERSION=1.5.0
ARROW_VERSION=0.13.2
ARROW_VERSION=1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump this to 1.0.1, too?

i-walker
i-walker reviewed Feb 3, 2022
View reviewed changes
gradle/libs.version.toml Outdated
[versions]
android = "7.0.4"
arrow = "1.0.1"
arrowGradleConfig = "0.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be 0.9.1-alpha.3

i-walker
i-walker reviewed Feb 3, 2022
View reviewed changes
build.gradle.kts Outdated
Comment on lines 2 to 8
alias(libs.plugins.kotlin.jvm) apply false
alias(libs.plugins.arrowGradleConfig.kotlin)
alias(libs.plugins.kotest.multiplatform) apply false
alias(libs.plugins.kotlin.binaryCompatibilityValidator)
alias(libs.plugins.arrowGradleConfig.nexus)
alias(libs.plugins.arrowGradleConfig.versioning)
alias(libs.plugins.arrowGradleConfig.publish)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alias(libs.plugins.kotlin.jvm) apply false
alias(libs.plugins.arrowGradleConfig.kotlin)
alias(libs.plugins.kotest.multiplatform) apply false
alias(libs.plugins.kotlin.binaryCompatibilityValidator)
alias(libs.plugins.arrowGradleConfig.nexus)
alias(libs.plugins.arrowGradleConfig.versioning)
alias(libs.plugins.arrowGradleConfig.publish)
alias(libs.plugins.dokka)
alias(libs.plugins.animalSniffer) apply false
alias(libs.plugins.kotest.multiplatform) apply false
alias(libs.plugins.kotlin.binaryCompatibilityValidator)
alias(libs.plugins.arrowGradleConfig.nexus)
alias(libs.plugins.arrowGradleConfig.versioning)

i-walker
i-walker reviewed Feb 3, 2022
View reviewed changes
gradle/libs.version.toml Outdated
arrow-gradleConfig-formatter = { id = "io.arrow-kt.arrow-gradle-config-formatter", version.ref = "arrowGradleConfig" }
arrow-gradleConfig-versioning = { id = "io.arrow-kt.arrow-gradle-config-versioning", version.ref = "arrowGradleConfig" }
dokka = { id = "org.jetbrains.dokka", version.ref = "dokka" }
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're missing kapt unless this is not needed anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arrow proper is using ksp?

@i-walker
Copy link
Member

i-walker commented Feb 3, 2022

Lets get this merged :D And do the other changes in another PR Thanks ✊🏾

@i-walker i-walker merged commit 94c7a23 into main Feb 3, 2022
@i-walker i-walker deleted the issue/update-jackson branch February 3, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-walker i-walker i-walker approved these changes

@nomisRev nomisRev Awaiting requested review from nomisRev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

["Request"] Upgrade Jackson to 2.13.1
2 participants
@myuwono @i-walker