Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for 2.0 #333

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Release for 2.0 #333

wants to merge 25 commits into from

Conversation

serras
Copy link
Member

@serras serras commented Oct 3, 2024

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @serras 🙌 🚀

Comment on lines 32 to 34
between fail-first and [accumulation of errors](/learn/typed-errors/working-with-typed-errors/#accumulating-different-computations). Until now, the latter mode
required using `parZip` and `parMap`, which sometimes obscure the actual
flow of the computation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parZip and parMap are used for parallel operations. Did you mean zipOrAccumulate here?

Comment on lines 43 to 46
parZip(
{ checkOneThing() },
{ checkOtherThing() }
) { a, b -> doSomething(a, b) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parZip(
{ checkOneThing() },
{ checkOtherThing() }
) { a, b -> doSomething(a, b) }
zipOrAccumulate(
{ checkOneThing() },
{ checkOtherThing() }
) { a, b -> doSomething(a, b) }

These examples are using context receivers, and/or omitting quite some details. Is it important for us the examples are real-life, and copy-paste able?

usual `async` mechanism, ensuring that all `Deferred` values are `await`ed
once the first one is requested. That means that the previous code behaves
identically to the following, that is, the call `file.await()` implicitly
awaits every `async` defined up to that point.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add the details why this is important for Raise, or how not using this could result in hanging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a 1-sentence summary of this I could use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates needed for 2.0
3 participants