fix(async): withStatusesAtom missing ctx

artalar · Jul 21, 2023 · a2e2e38 · a2e2e38 · vercel · Jul 21, 2023
1 parent 3dc60dc
commit a2e2e38
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/packages/async/src/index.test.ts b/packages/async/src/index.test.ts
@@ -17,6 +17,7 @@ import {
 
 import './index.story.test'
 import './withCache.test'
+import './withStatusesAtom.test'
 import './mapToAsync.test'
 
 test(`base API`, async () => {

diff --git a/packages/async/src/withStatusesAtom.test.ts b/packages/async/src/withStatusesAtom.test.ts
@@ -113,7 +113,6 @@ test('withCache and withStatusesAtom', async () => {
   const fetchData = reatomAsync(async (ctx, shouldTrow = false) => {
     if (shouldTrow) throw new Error('withStatusesAtom test error')
   }).pipe(
-    // withCache(),
     withStatusesAtom(),
     withCache(),
   )
@@ -137,9 +136,8 @@ test('withCache and withStatusesAtom', async () => {
 
   assert.is(track.calls.length, 4)
   assert.equal(track.lastInput(), anotherPending)
-  fetchData(ctx, true)
-  // TODO this extra call is not correct, but it is not critical
-  assert.is(track.calls.length, 5)
+  fetchData(ctx, true).catch(() => {})
+  assert.is(track.calls.length, 4)
   assert.equal(track.lastInput(), anotherPending)
 
   await promise2.catch(() => {})

diff --git a/packages/async/src/withStatusesAtom.ts b/packages/async/src/withStatusesAtom.ts
@@ -143,7 +143,7 @@ export const withStatusesAtom =
         __thenReatomed(
           ctx,
           payload,
-          (ctx) =>
+          () =>
             statusesAtom(
               ctx,
               memo(() => {