feat(jsx): normalize class attribute #942
Open
+200
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
a7e468f
to
447e759
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
447e759
to
913f694
Compare
kasperskei
commented
Oct 15, 2024
| @@ -303,7 +303,7 @@ it('custom component', setup((ctx, h, hf, mount, parent) => { | |||
| const Component = (props: JSX.HTMLAttributes) => <div {...props} /> | |||
|
|
|||
| assert.instance(<Component />, window.HTMLElement) | |||
| assert.is(((<Component draggable />) as HTMLElement).draggable, true) | |||
| assert.is(((<Component draggable="true" />) as HTMLElement).draggable, true) | |||
There was a problem hiding this comment.
Attribute is not boolean. That's why the tests failed.
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/draggable
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
913f694
to
1681ced
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
f64a1a8
to
5936224
Compare
kasperskei
force-pushed
the
jsx-normalize-class
branch
from
5936224
to
04fa070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class binding like vue.js.