-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: Images on static pages overflow on the bootstrap 5 theme #1610
Comments
Just as an FYI, depending on how you address this: there are 2 places in the docs that should probably be reviewed in light of however you proceed. One option is simply to document the recommendation to use the The Manage Static Pages documentation page includes a section on formatting. This covers some basic HTML examples that can be used on static pages, and the Images subsection includes some BS2 classes that may no longer be relevant: This whole section also links to the Formatting documentation page on Markdown use: |
To avoid changing all existing static pages, we could add some default CSS rules to all images in all static pages ( |
Thanks @fiver-watson! Will review the docs and update them. A lot of those existing classes seem to still be valid, but it would be good to document image classes for Bootstrap 5. @jraddaoui Yup! That's the plan for the next release. The |
* Fixed password reset tool Symfony task description text * Made task use the standard AtoM base class for tasks
Created a PR for AtoM docs updates for changes related to BS5 classes: artefactual/atom-docs#223 |
Add css styles to fix overflowing images in static pages with large width.
Add css styles to fix overflowing images in static pages with large width.
Add a max-width to fix overflowing images in static pages with large width.
Add a max-width to fix overflowing images in static pages with large width.
Add a max-width to fix overflowing images in static pages with large width.
Current Behavior
Steps to reproduce the behavior
Expected Behavior
Image should not grow outside the container.
Possible Solution
This likely stems from Bootstrap 5 removing the
max-width: 100%
style from theimg
tag. It probably doesn't show up in other places because the classes applied to images elsewhere take care of this.A temporary way to fix this on static pages in the meantime would be to add a
class="img-fluid"
to any images to fix this.Version used
AtoM 2.7.2
The text was updated successfully, but these errors were encountered: