Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: tools:rename-slug: error handling #1666

Closed
melaniekung opened this issue Sep 25, 2023 · 1 comment · Fixed by #1669
Closed

Problem: tools:rename-slug: error handling #1666

melaniekung opened this issue Sep 25, 2023 · 1 comment · Fixed by #1669
Assignees
@melaniekung
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone
2.8.0

Comments

@melaniekung
Copy link
Contributor

melaniekung commented Sep 25, 2023 •
edited
Loading

Current Behavior

When running the rename-slug tool, if the destination slug (newSlug) already exists, the tool exits with an error:

Image

Unable to execute UPDATE statement. [wrapped: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'wragge-sydney' for key 'slug.slug\_U\_2']

This is because the slug wragge-sydney already exists.

Expected Behavior

Script should continue when an error is encountered and print a list of failed renames in the console output STDOUT.
@melaniekung melaniekung added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Sep 25, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Sep 25, 2023
@melaniekung melaniekung self-assigned this Sep 25, 2023
melaniekung added a commit that referenced this issue Sep 25, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
7859663
melaniekung added a commit that referenced this issue Sep 25, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
b3e4f22
melaniekung added a commit that referenced this issue Sep 25, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
cb8762e
melaniekung added a commit that referenced this issue Sep 25, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
d9bddad
melaniekung added a commit that referenced this issue Sep 26, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
62f968a
melaniekung added a commit that referenced this issue Sep 26, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
9021db2
melaniekung added a commit that referenced this issue Sep 26, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
01515ad
melaniekung added a commit that referenced this issue Sep 26, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
5a44df2
melaniekung added a commit that referenced this issue Sep 28, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
c5c9a3b
melaniekung added a commit that referenced this issue Sep 28, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666)
d601420
melaniekung added a commit that referenced this issue Sep 28, 2023
@melaniekung
Add error handling for tools:rename-slug. (#1666) (#1669)
48e1fa3
@melaniekung
Copy link
Contributor Author

melaniekung commented Oct 3, 2023 •
edited
Loading

PR: 48e1fa3

@anvit anvit linked a pull request Oct 4, 2023 that will close this issue
Add error handling for tools:rename-slug. (#1666) #1669
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melaniekung melaniekung

Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Add error handling for tools:rename-slug. (#1666) artefactual/atom
1 participant
@melaniekung