Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Invalid static pages are created with invalid slugs #1703

Closed
melaniekung opened this issue Nov 6, 2023 · 0 comments · Fixed by #1705 or #1707
Closed

Problem: Invalid static pages are created with invalid slugs #1703

melaniekung opened this issue Nov 6, 2023 · 0 comments · Fixed by #1705 or #1707
Assignees
@melaniekung
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone
2.8.0

Comments

@melaniekung
Copy link
Contributor

melaniekung commented Nov 6, 2023 •
edited
Loading

Current Behavior

Steps to reproduce the behavior

  1. Create a static page with an invalid url (ex. "test.123")
  2. Notice that the page is created but cannot be used or deleted.

Expected Behavior

Throw an error if slug is invalid and do not create record.
@melaniekung melaniekung added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Nov 6, 2023
@melaniekung melaniekung self-assigned this Nov 6, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Nov 6, 2023
melaniekung added a commit that referenced this issue Nov 6, 2023
@melaniekung
Add validation for static page slugs. (#1703)
36348d1
@melaniekung melaniekung linked a pull request Nov 6, 2023 that will close this issue
Add validation for static page slugs. (#1703) #1705
Merged
melaniekung added a commit that referenced this issue Nov 7, 2023
@melaniekung
Add validation for static page slugs. (#1703)
d1fc431
melaniekung added a commit that referenced this issue Nov 7, 2023
@melaniekung
Add validation for static page slugs. (#1703)
4bb9e53
melaniekung added a commit that referenced this issue Nov 7, 2023
@melaniekung
Add validation for static page slugs. (#1703) (#1705)
9bd6f13
melaniekung added a commit that referenced this issue Nov 8, 2023
@melaniekung
Fix validation for static page slugs. (#1703)
60a0432
@melaniekung melaniekung linked a pull request Nov 8, 2023 that will close this issue
Don't modify pattern option on render_field helper. (#1703) #1707
Merged
melaniekung added a commit that referenced this issue Nov 9, 2023
@melaniekung
Fix validation for static page slugs. (#1703) (#1707)
04282e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melaniekung melaniekung

Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.0
1 participant
@melaniekung