Add support for Egypt TIN #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unho
force-pushed
the
eg-tin
branch
6 times, most recently
from
9ebb6b1
to
4bb5d70
Compare
|
Sorry it took so long but I merged this with a small fix to the compact() function for Python 2.7 in 6d366e3. It is not ideal because there is no clear description of the number I could find (but that is probably also due to my not being able to grasp Arabic) and the lack of validation of a checksum or check digit but the presence of the conversion still is useful. |
|
For this particular PR there was something that didn't work with the CI that I was unable to figure out. Thank you very much for fixing that glitch and merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #225.