Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example node-cache implementation in docs #841

Merged
merged 4 commits into from
May 30, 2024

Conversation

sinarck
Copy link
Contributor

@sinarck sinarck commented May 22, 2024

I recently wrote some code in my own project that utilizes node-cache, and thought it might be helpful for anyone else who stumbled across the docs. I'm not sure if my implementation is actually useful or correct, so any feedback would be helpful.

@sinarck sinarck changed the title docs: added example for node-cache in storages.md Add an example node-cache implementation in docs May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (a30f8d2) to head (ac727bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          19       19           
  Lines        2442     2442           
  Branches      212      211    -1     
=======================================
  Hits         2424     2424           
  Misses         17       17           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurfiorette
Copy link
Owner

there's syntax errors in your example

@sinarck
Copy link
Contributor Author

sinarck commented May 22, 2024

Should be good now.

@arthurfiorette arthurfiorette merged commit 77a8f7a into arthurfiorette:main May 30, 2024
6 checks passed
@arthurfiorette
Copy link
Owner

thanks!

@sinarck sinarck deleted the patch-1 branch May 30, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants