Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on unsafe_op_in_unsafe_fn #106

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Warn on unsafe_op_in_unsafe_fn #106

merged 1 commit into from
Nov 18, 2021

Conversation

lopopolo
Copy link
Member

Add a pragma to the crate root to require unsafe operations inside
unsafe fn to be wrapped in an unsafe block.

This adds one additional safety comment where one was missing.

@lopopolo
Warn on unsafe_op_in_unsafe_fn
d0f0d7b 
Add a pragma to the crate root to require unsafe operations inside
`unsafe fn` to be wrapped in an unsafe block.

This adds one additional safety comment where one was missing.
@lopopolo lopopolo added A-security Area: Security vulnerabilities and unsoundness issues. I-bytes Interner: Byte string SymbolTable. I-str Interner: UTF-8 string SymbolTable. C-quality Category: Refactoring, cleanup, and quality improvements. labels Nov 18, 2021
@lopopolo lopopolo merged commit a077572 into trunk Nov 18, 2021
@lopopolo lopopolo deleted the warn-unsafe_op_in_unsafe_fn branch November 18, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-security Area: Security vulnerabilities and unsoundness issues. C-quality Category: Refactoring, cleanup, and quality improvements. I-bytes Interner: Byte string SymbolTable. I-str Interner: UTF-8 string SymbolTable.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lopopolo