Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and coverage for fmt::Debug impls of slice internals #237

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Add tests and coverage for fmt::Debug impls of slice internals #237

merged 2 commits into from
Jul 26, 2023

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Jul 26, 2023 •
edited
Loading

Addresses reduction in coverage when adding PinBox type for Slice internals in #236.

@lopopolo lopopolo added C-quality Category: Refactoring, cleanup, and quality improvements. A-interner Area: String interners, data structures, and types. labels Jul 26, 2023
@lopopolo
Copy link
Member Author

Miri is failing as expected due to #235. This fix unblocks #236 which resolves #235, so I'll merge without Miri being green.

@lopopolo lopopolo merged commit 6b7568c into trunk Jul 26, 2023
17 of 18 checks passed
@lopopolo lopopolo deleted the lopopolo/internal-fmt-debug-code-coverage branch July 26, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-interner Area: String interners, data structures, and types. C-quality Category: Refactoring, cleanup, and quality improvements.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lopopolo