-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run basic examples as tests #2006
Conversation
107e447
to
e8b2016
Compare
Hey, @hassy. Would you have a minute to look at this please? The test -> workflow usage should be straightforward but the main area I'd like to hear feedback on is the test runner itself. Thanks! |
While we were discussing this, I got an interesting idea. I was thinking how can we feature out GitHub Action in the examples to encourage best practices of CI setups while keeping the testing setup manageable on our end (each example controlling its own CI). I think if I invert the control here, and let each example define its own workflow and then the top-level one just reuse those, we can get the best of both worlds:
The current setup is somewhat closer to what I found on GitHub docs:
I think we should be able to move that "template" to examples themselves. Will prepare a commit that illustrates that. |
976a74f
to
4f3fc37
Compare
Alas, that's not going to work. GitHub Actions require reusable workflows to be on the root level of I've tried an absolute reference to the nested workflow (through I've tried symlinks as well, but GitHub doesn't resolve them; it actually tries to read as symlink as a binary and fails.
|
88f8346
to
897e56e
Compare
I've opened artilleryio/action-cli#9 to support running our example tests against the current build of Artillery. Once that's released, I can update the tests to point to the in-repo version of the CLI so tests help us catch regressions before they are merged. |
8869bef
to
c24a840
Compare
With artilleryio/action-cli#9 merged, I've updated the test workflows to point to the local version of Artillery CLI. All the introduced examples are not passing against that version 🎉 This will help us catch any regressions faster. There are no more changes necessary to merge this. Ready for review. |
c24a840
to
fea5763
Compare
Looks good to go! Could you update the commit log before merge to remove WIP commits. |
fea5763
to
c393182
Compare
chore: set job timeout to 60 minutes chore: define workflow next to the example
chore: patch artillery binary chore: remove install steps from tests chore: set custom "working-directory" for tests
chore: use absolute artillery binary path chore: add install step to use custom binary
c393182
to
19e4f37
Compare
@hassy, I grouped the commits to reflect finite changes. Will wait for the CI and merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this change is to repurpose a basic set of usage examples as E2E tests running on each change to Artillery. This makes sure that:
Changes
Roadmap
Publish example runner if we decide to use it.