Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling #79

Closed
wants to merge 7 commits into from
Closed

Fix compiling #79

wants to merge 7 commits into from

Conversation

kalwalt
Copy link

@kalwalt kalwalt commented Feb 12, 2019

This pull request wants to fix the code that fails during the building process and try to improve it a little bit.
it is related to this issue #78
In the specific;

  • The building process fails while try to build the libar.bc because including the file Video/VideoLuma.c
  • i added an env var to link emscripten in the package.json file
  • minor things (cleaning the code)

I have tested only on a linux machine, i have no idea for other OS (Windows, Mac..) , I used to build the lib the latest emscripten 1.38.26.
Let me know if you think that the code should be merged or not.

@kalwalt
Copy link
Author

kalwalt commented Feb 13, 2019

I receive this error running the simple_video.html example ( and the others using the debug lib):

artoolkit.api.js:1148 Uncaught TypeError: artoolkit.setup is not a function
    at ARController._initialize (artoolkit.api.js:1148)
    at ARController.<anonymous> (artoolkit.api.js:111)
    at ARCameraParam.<anonymous> (artoolkit.api.js:1591)
    at writeCallback (artoolkit.api.js:1785)
    at writeByteArrayToFS (artoolkit.api.js:1811)
    at XMLHttpRequest.oReq.onload (artoolkit.api.js:1828) 

i saw this issue #40 but it seems that now the debug lib is affected and not the minifyied lib...

@kalwalt
Copy link
Author

kalwalt commented Dec 18, 2019

this PR is outdated, will be closed. Follow this new #86

@kalwalt kalwalt closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant