-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ignore price database #40
Conversation
"NOT *L2FydGljbGVz*", | ||
"NOT *L2FydGljbGUv*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MounirDhahri This PR removes these two entries completely. Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that. These two has been deleted after I ran yarn build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok> Thanks for clarifying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 . Looks good. I think we can merge if the deleted ones are not a problem.
🚀 PR was released in |
I apologize for the big diff, I alphabetically sorted the paths to make it easier to add new ones in the future.
This PR resolves https://artsyproduct.atlassian.net/browse/CX-2113
Description:
The goal of this PR is to make sure that the price-database link does not open the app and instead opens the link in the browser
Note:
The next steps here would be updating artsy-eigen-web-association in artsy-wwwify and force