Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@dylanfareed => Fix swagger shebang. #42

Merged
merged 2 commits into from
Sep 16, 2014

Conversation

dblock
Copy link
Contributor

@dblock dblock commented Sep 16, 2014

In the playground on developers.artsy.net you get an error: Docs.shebang: undefined is not a function. This was reported in swagger-api/swagger-ui#551, however this turned out to be a swagger setup problem in Doppler. The fix is to not include JQuery twice and to include JQuery BBQ after JQuery.

@@ -1,10 +1,10 @@
!!!
%html
= render 'shared/header'
= javascript_include_tag 'application'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like the move the js to the head and then to the end of the body and then back and forth is a dance we do increasingly these days.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👯

dylanfareed added a commit that referenced this pull request Sep 16, 2014
@dylanfareed dylanfareed merged commit 07ddd56 into artsy:master Sep 16, 2014
@dblock dblock deleted the fix-swagger-shebang branch September 16, 2014 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants