Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade sdwebimage #10012

Merged
merged 5 commits into from
Apr 1, 2024
Merged

chore: upgrade sdwebimage #10012

merged 5 commits into from
Apr 1, 2024

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Mar 29, 2024

This PR resolves PHIRE-753

Description

Updates SDWebImage to the latest which adds a privacy manifest to comply with apple requirements.

Since we get this from react-native-fast-image and there is not a release that supports latest yet a patch had to be added.

Once this issue is resolved we can remove and update to the latest version.
DylanVann/react-native-fast-image#1031

Images appear to work fine after the update:
images

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • update SDWebImage to the latest, patch react-native-fast-image - Brian

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Mar 29, 2024

This PR contains the following changes:

  • Dev changes (update SDWebImage to the latest, patch react-native-fast-image - Brian)

Generated by 🚫 dangerJS against dc771fd

@brainbicycle brainbicycle added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Apr 1, 2024
@artsy-peril artsy-peril bot merged commit 927d38a into main Apr 1, 2024
5 of 6 checks passed
@artsy-peril artsy-peril bot deleted the brian/upgrade-sdwebimage branch April 1, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants