Make each column scrollable, break on words in snippets #5693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lily Pace <[email protected]>
xtina-starr
reviewed
Jun 1, 2020
| interface ConversationRouteProps { | ||
| me: Conversation_me | ||
| conversationID: string | ||
| match: Match | ||
| } | ||
|
|
||
| const ConstrainedHeightFlex = styled(Flex)` | ||
| height: calc(100vh - 145px); |
There was a problem hiding this comment.
Just curious what does the 145px represent?
There was a problem hiding this comment.
Oh is that accounting for the header thing that contains Inbox, Conversation with..., etc?
There was a problem hiding this comment.
It is indeed. Might add a comment here to make that clearer.
xtina-starr
reviewed
Jun 1, 2020
| @@ -25,7 +25,7 @@ const TimeSinceFlex = styled(Flex)` | |||
| ` | |||
|
|
|||
| const StyledSans = styled(Sans)` | |||
| word-break: break-all; | |||
| word-break: break-word; | |||
xtina-starr
approved these changes
Jun 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PURCHASE-1908
Ensures that each panel in a conversation scrolls individually.
Before
After
